kbendick commented on a change in pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#discussion_r503483147
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergFilterFactory.java
##########
@@ -207,8 +206,8 @@ public void testBooleanType() {
@Test
public void testDateType() {
SearchArgument.Builder builder = SearchArgumentFactory.newBuilder();
- Date gmtDate = new Date(LocalDate.of(2015, 11,
12).atStartOfDay(ZoneOffset.UTC).toInstant().toEpochMilli());
- SearchArgument arg = builder.startAnd().equals("date",
PredicateLeaf.Type.DATE, gmtDate).end().build();
+ Date date = Date.valueOf("2015-11-12");
Review comment:
I had a feeling this method was purposely not used, but I wasn't sure of
a better option so I figured I'd open the PR and then let somebody point it
out. I also figured that the flakey test was indicative of more than just a
flakey test. I'll apply your suggestions this evening after work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
