rdblue commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2274502938


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTestBase.java:
##########
@@ -603,4 +603,57 @@ public void testRowLineage() throws Exception {
             record.copy(Map.of("id", 4L, "data", "d", "_row_id", 1_001L)),
             record.copy(Map.of("id", 5L, "data", "e"))));
   }
+
+  @Test
+  public void testUnknownTopLevel() throws IOException {

Review Comment:
   This should be covered by the existing `testTypeSchema` test: 
https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTestBase.java#L164-L190
   
   I think it's also good to test the map and list restrictions and I like that 
this has a nested type as well. Maybe we should update the general type test to 
support a nested case rather than adding another one though?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to