kevinjqliu opened a new pull request, #2331:
URL: https://github.com/apache/iceberg-python/pull/2331

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace 
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   
   # Rationale for this change
   Closes #2328
   
   
[`pyarrow.fs.AzureFileSystem`](https://arrow.apache.org/docs/python/generated/pyarrow.fs.AzureFileSystem.html)
 does not currently expose credential as a parameter 
   
   # Are these changes tested?
   Yes, manually since azurite does not integrate with entra. 
   
   heres a repro script
   ```
   from azure.identity import DefaultAzureCredential
   import pyarrow as pa
   
   credential = DefaultAzureCredential()
   token = credential.get_token("https://storage.azure.com/.default";).token
   
   warehouse = 
"abfss://kevinliu_demo...@daily-onelake.blob.fabric.microsoft.com/kevinliu_demo_lh.Lakehouse/Files"
   account_name = "daily-onelake"
   account_host = f"{account_name}.blob.fabric.microsoft.com"
   
   catalog = load_catalog("default", **{
       "type": "in-memory", 
       "warehouse": warehouse,
       "adls.account-name": account_name,
       "adls.account-host": account_host,
       "adls.token": token,
   })
   
   catalog.create_namespace_if_not_exists("default")
   try:
       catalog.drop_table("default.test")
   except:
       ...
   
   
   TEST_DATA = {
       "id": [1, 2, 3, 1, 1],
       "name": ["AB", "CD", "EF", "CD", "EF"],
   }
   arrow_table = pa.Table.from_pydict(TEST_DATA)
   tbl = catalog.create_table_if_not_exists("default.test", 
schema=arrow_table.schema)
   tbl.append(arrow_table)
   tbl.scan().to_arrow()
   ```
   
   
   
   # Are there any user-facing changes?
   
   <!-- In the case of user-facing changes, please add the changelog label. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to