RussellSpitzer commented on code in PR #13780:
URL: https://github.com/apache/iceberg/pull/13780#discussion_r2279775195
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -197,7 +197,12 @@ private static Type typeFromJson(JsonNode json) {
private static Literal<?> defaultFromJson(String defaultField, Type type,
JsonNode json) {
if (json.has(defaultField)) {
- return Expressions.lit(SingleValueParser.fromJson(type,
json.get(defaultField)));
Review Comment:
This is a problem for 1.10? Should we block the release on this? While I
know the chances are unlikely here but if anyone is trying to set defaults
close to Epoch they won't Overflow and will instead write incorrect values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
