HeartLinked commented on code in PR #176:
URL: https://github.com/apache/iceberg-cpp/pull/176#discussion_r2281202634
##########
src/iceberg/manifest_writer.h:
##########
@@ -51,13 +61,27 @@ class ICEBERG_EXPORT ManifestWriter {
class ICEBERG_EXPORT ManifestListWriter {
public:
virtual ~ManifestListWriter() = default;
- virtual Status WriteManifestFiles(const std::vector<ManifestFile>& files)
const = 0;
+
+ /// \brief Write manifest file list to manifest list file.
Review Comment:
The comment "Write manifest file list" here is inconsistent with the
single-add function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
