openinx commented on issue #1578: URL: https://github.com/apache/iceberg/issues/1578#issuecomment-707465328
> If you needed to register a logical type, then you must be using Avro's DatumReader instead of an Iceberg DatumReader. Yes, you're right. Here is the code: https://github.com/apache/iceberg/pull/1477/files#diff-863fca4ad067cd7dd66730275ed9dcb29fa4468b5b474461934bda9372f73280R72. It just use the GenericAvroReader to decode the datum. I see the `IcebergDecoder` & `IcebergEncoder` could only encode/decode the iceberg `Record`, while `ManifestFile` is a `IndexedRecord`, in theory we should define the `AvroDecoder` and `AvroEncoder`, and providing those tests to address the schema evolution issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
