nastra commented on code in PR #13847:
URL: https://github.com/apache/iceberg/pull/13847#discussion_r2282790407
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -119,6 +120,19 @@ static void validateTableIsIcebergView(Table table, String
fullName) {
table.getTableType());
}
+ static void validateLoadIcebergTableAsIcebergView(Table table, String
fullName) {
+ String tableType =
table.getParameters().get(BaseMetastoreTableOperations.TABLE_TYPE_PROP);
+ boolean isIcebergTable =
+ tableType != null
Review Comment:
if you do the check the other way around, then you don't need the null
check:
`BaseMetastoreTableOperations.ICEBERG_TABLE_TYPE_VALUE.equalsIgnoreCase(tableTypeProp)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
