hackintoshrao commented on PR #527:
URL: https://github.com/apache/iceberg-go/pull/527#issuecomment-3198803979
@laskoviymishka Thanks for the feedback, you're right, it's a fake, not a
mock.
My goal was to validate the contract of the Requirement interface, but
using a fake defeats that purpose since it doesn't test real behavior. It just
tests against my own simplified implementation. Apologies for the naivety here;
this is a rare mistake on my part.
I see that to test the contract correctly, I need to use a real
TableMetadataBuilder and test against actual metadata lifecycle scenarios
rather than artificial ones.
I'll rework this to:
- Build metadata using the real builder/update mechanisms
- Test requirements against actual metadata state transitions
- Use errors.Is instead of string matching
- Make the tests more straightforward and more explicit
My primary concern is to ensure that no unintended changes are introduced
into the implementation that might affect upstream users of the library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
