kevinjqliu commented on code in PR #2340:
URL: https://github.com/apache/iceberg-python/pull/2340#discussion_r2284009145
##########
pyiceberg/table/__init__.py:
##########
@@ -431,7 +431,9 @@ def update_schema(self, allow_incompatible_changes: bool =
False, case_sensitive
name_mapping=self.table_metadata.name_mapping(),
)
- def update_snapshot(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT, branch: Optional[str] = None) -> UpdateSnapshot:
+ def update_snapshot(
+ self, snapshot_properties: Dict[str, str] = EMPTY_DICT, branch:
Optional[str] = MAIN_BRANCH
Review Comment:
looks like there are a lot of places where we do `branch: Optional[str] =
None`
https://grep.app/search?f.repo=apache%2Ficeberg-python&f.repo.pattern=iceberg-python&q=branch%3A+Optional%5Bstr%5D+%3D+None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
