kevinjqliu commented on code in PR #13835:
URL: https://github.com/apache/iceberg/pull/13835#discussion_r2284999086
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -388,26 +388,23 @@ private int nextFieldId() {
return lastAssignedFieldId.incrementAndGet();
}
- private void checkAndAddPartitionName(String name) {
- checkAndAddPartitionName(name, null);
- }
-
Builder checkConflicts(boolean check) {
checkConflicts = check;
return this;
}
- private void checkAndAddPartitionName(String name, Integer sourceColumnId)
{
+ private void checkAndAddPartitionName(
Review Comment:
those are all good points, let me see if i can refactor some more :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
