osscm commented on issue #13850:
URL: https://github.com/apache/iceberg/issues/13850#issuecomment-3201586317

   it is already using the 
   
   > Thanks [@tgorthi](https://github.com/tgorthi) for raising this.
   > 
   > Looking at the code, it should use the `lastcolumnId`:
   > 
   > 
[iceberg/core/src/main/java/org/apache/iceberg/SchemaUpdate.java](https://github.com/apache/iceberg/blob/389c04cfb0d97c34d8321439f501f9b1c0f7d72d/core/src/main/java/org/apache/iceberg/SchemaUpdate.java#L69-L80)
   > 
   > Lines 69 to 80 in 
[389c04c](/apache/iceberg/commit/389c04cfb0d97c34d8321439f501f9b1c0f7d72d)
   > 
   >  SchemaUpdate(TableOperations ops) { 
   >    this(ops, ops.current()); 
   >  } 
   >   
   >  /** For testing only. */ 
   >  SchemaUpdate(Schema schema, int lastColumnId) { 
   >    this(null, null, schema, lastColumnId); 
   >  } 
   >   
   >  private SchemaUpdate(TableOperations ops, TableMetadata base) { 
   >    this(ops, base, base.schema(), base.lastColumnId()); 
   >  } 
   > Let's dig into this together to see if we can get this fixed
   
   this is an interesting problem, I'm also interested as we have also 
encountered the similar scenario. 
   
   Trying to understand so pardon me, looks like this code is already using 
`lastColumnId` or I'm missing something?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to