ebyhr commented on code in PR #13868:
URL: https://github.com/apache/iceberg/pull/13868#discussion_r2286983225
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -101,6 +102,10 @@ public class RewriteDataFilesSparkAction
super(spark.cloneSession());
// Disable Adaptive Query Execution as this may change the output
partitioning of our write
spark().conf().set(SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(), false);
+ // Disable executor cache for delete files as each partition is rewritten
separately.
+ // Note: when compacting to a different target spec, data from multiple
partitions
+ // may be grouped together, but caching is still disabled to avoid
connection pool issues.
Review Comment:
I think you should fix v4.0 first. Using diffferent comments among versions
doesn't make sense to me.
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -101,6 +102,10 @@ public class RewriteDataFilesSparkAction
super(spark.cloneSession());
// Disable Adaptive Query Execution as this may change the output
partitioning of our write
spark().conf().set(SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(), false);
+ // Disable executor cache for delete files as each partition is rewritten
separately.
+ // Note: when compacting to a different target spec, data from multiple
partitions
+ // may be grouped together, but caching is still disabled to avoid
connection pool issues.
Review Comment:
I think you should fix v4.0 first. Using different comments among versions
doesn't make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
