nastra commented on code in PR #13859:
URL: https://github.com/apache/iceberg/pull/13859#discussion_r2288155677
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java:
##########
@@ -440,31 +446,30 @@ public void testUuidReads() throws Exception {
assertRecordsMatch(schema, numRows, data, dataFile, false, BATCH_SIZE);
}
- private void assertIdenticalFileContents(File actual, File expected, Schema
schema)
- throws IOException {
- try (CloseableIterable<InternalRow> actualReader =
- Parquet.read(Files.localInput(actual))
- .project(schema)
- .createReaderFunc(t -> SparkParquetReaders.buildReader(schema, t,
ID_TO_CONSTANT))
- .build()) {
- Iterator<InternalRow> actualIterator = actualReader.iterator();
- try (CloseableIterable<InternalRow> plainReader =
- Parquet.read(Files.localInput(expected))
- .project(schema)
- .createReaderFunc(t -> SparkParquetReaders.buildReader(schema,
t, ID_TO_CONSTANT))
- .build()) {
- Iterator<InternalRow> expectedIterator = plainReader.iterator();
-
- List<InternalRow> expectedList = Lists.newArrayList();
- expectedIterator.forEachRemaining(expectedList::add);
- List<InternalRow> actualList = Lists.newArrayList();
- actualIterator.forEachRemaining(actualList::add);
-
- assertThat(actualList)
- .as("Comparison between files failed %s <-> %s", actual, expected)
- .isNotEmpty()
- .hasSameSizeAs(expectedList)
- .hasSameElementsAs(expectedList);
+ private void assertIdenticalFileContents(
Review Comment:
I'm a little confused as to why Spark 4 code is being modified in this PR,
since the goal of this PR is to only backport things to Spark 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
