hsiang-c commented on code in PR #13434:
URL: https://github.com/apache/iceberg/pull/13434#discussion_r2288815866
##########
dell/src/test/java/org/apache/iceberg/dell/ecs/TestEcsCatalog.java:
##########
@@ -174,6 +174,7 @@ public void testRenameTable() {
@Test
public void testRegisterTable() {
+ ecsCatalog.createNamespace(Namespace.of("a"));
Review Comment:
It is because
1. `EcsCatalog` implements `SupportsNamespaces` and the
`targetNamespaceExists` I introduced requires an existent namespace.
2. `TestEcsCatalog` doesn't implement `CatalogTests<EcsCatalog>` and it
doesn't know about the `requiresNamespaceCreate` method. Therefore, unlike the
`testRegisterTable` in `CatalogTests`, this test doesn't create a namespace
beforehand so I created it here.
```java
@Test
public void testRegisterTable() {
C catalog = catalog();
if (requiresNamespaceCreate()) {
catalog.createNamespace(TABLE.namespace());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
