emkornfield commented on PR #1502: URL: https://github.com/apache/iceberg-rust/pull/1502#issuecomment-3208051757
I'm new to reviewing, but the code itself mostly looks fine. My main concern is around potential span bloat. the "eval" level trace and the per manifest level traces seems like they could easily blow-out what most systems have configured for trace depth (e.g. maybe these should be debug only)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
