RussellSpitzer commented on code in PR #13880:
URL: https://github.com/apache/iceberg/pull/13880#discussion_r2289459254
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java:
##########
@@ -99,7 +100,7 @@ public static List<Object[]> parameters() {
for (FileFormat format :
new FileFormat[] {FileFormat.AVRO, FileFormat.ORC,
FileFormat.PARQUET}) {
for (Object[] catalogParams : CatalogTestBase.parameters()) {
- for (int version : Arrays.asList(2, 3)) {
+ for (int version : TestHelpers.V2_AND_ABOVE) {
Review Comment:
Same here
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergCommitter.java:
##########
@@ -157,7 +158,7 @@ class TestIcebergCommitter extends TestBase {
protected static List<Object> parameters() {
List<Object> parameters = Lists.newArrayList();
for (Boolean isStreamingMode : new Boolean[] {true, false}) {
- for (int formatVersion : new int[] {1, 2}) {
+ for (int formatVersion : TestHelpers.ALL_VERSIONS) {
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
