rdblue commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2289516194
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/TypeToSparkType.java:
##########
@@ -130,9 +131,10 @@ public DataType primitive(Type.PrimitiveType primitive) {
case DECIMAL:
Types.DecimalType decimal = (Types.DecimalType) primitive;
return DecimalType$.MODULE$.apply(decimal.precision(),
decimal.scale());
+ case UNKNOWN:
+ return NullType$.MODULE$;
default:
- throw new UnsupportedOperationException(
- "Cannot convert unknown type to Spark: " + primitive);
+ throw new UnsupportedOperationException("Type not known to Spark: " +
primitive);
Review Comment:
What about `"Cannot convert unsupported type to Spark: "` instead? I like
changing the message less, but still removing "unknown" since it is now
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
