rdblue commented on a change in pull request #1607:
URL: https://github.com/apache/iceberg/pull/1607#discussion_r504107965
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerBaseTest.java
##########
@@ -230,6 +276,250 @@ public void testJoinTables(FileFormat format) throws
IOException {
Assert.assertArrayEquals(new Object[] {1L, "Bob", 102L, 33.33d},
rows.get(2));
}
+ private void testArrayTypeInTable(FileFormat format) throws IOException {
+ final Schema schema = new Schema(
+ required(1, "arrayofprimitives", Types.ListType.ofRequired(
Review comment:
Style:
* We don't use `final` for local variables because Java does a good job of
inferring it and it is debatable whether it actually helps the compiler make
better decisions.
* The indentation is off. It should be 4 spaces (2 indents) for a continuing
indent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
