GeetKrishna commented on code in PR #1617:
URL: https://github.com/apache/iceberg-rust/pull/1617#discussion_r2292580527


##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -1717,6 +1734,60 @@ mod tests {
         }
     }
 
+    #[test]

Review Comment:
   I implemented an integration test for unsigned type roundtrip, but 
discovered that ParquetWriter also requires modification to handle unsigned 
data conversion. The issue stems from a type mismatch between schema and data.
   
   The problem occurs because schema conversion (`arrow_schema_to_schema`) 
transforms the metadata but leaves the actual data unchanged. When writing, 
Arrow validation fails due to this mismatch.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to