mxm commented on code in PR #13883: URL: https://github.com/apache/iceberg/pull/13883#discussion_r2294100134
########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TablePropertiesUpdater.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.sink.dynamic; + +import java.io.Serializable; +import java.util.Map; + +@FunctionalInterface +public interface TablePropertiesUpdater extends Serializable { Review Comment: I was contemplating to add the properties to DynamicRecord, but I decided against it because table properties aren't directly connected to the data. Perhaps there are other table-related settings like the table location which users want to control (this has already been requested by users). The location would only be settable during table creation. Using a separate interface we would be better able to express this intent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
