kevinjqliu commented on code in PR #2374:
URL: https://github.com/apache/iceberg-python/pull/2374#discussion_r2294486611
##########
mkdocs/docs/verify-release.md:
##########
@@ -48,13 +48,18 @@ Set an environment variable to the version to verify and
path to use
```sh
export PYICEBERG_VERSION=<version> # e.g. 0.6.1rc3
+```
+
+And a temp folder for the artifacts
+
+```sh
export PYICEBERG_VERIFICATION_DIR=/tmp/pyiceberg/${PYICEBERG_VERSION}
```
Next, verify the `.asc` file.
```sh
-svn checkout
https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-${PYICEBERG_VERSION}/
${PYICEBERG_VERIFICATION_DIR}
+svn checkout
https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-$PYICEBERG_VERSION/
${PYICEBERG_VERIFICATION_DIR}
Review Comment:
previously `${PYICEBERG_VERSION}` would expand to `$\{PYICEBERG_VERSION\}/`
in iterm and mess up the url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
