dramaticlly commented on code in PR #13720:
URL: https://github.com/apache/iceberg/pull/13720#discussion_r2294827061
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -85,6 +86,14 @@ public Set<T> toRewrite() {
public Set<Pair<String, String>> copyPlan() {
return copyPlan;
}
+
+ public Long length() {
+ return length;
+ }
+
+ public void length(long newLength) {
+ this.length = newLength;
+ }
Review Comment:
Actually this alerts the revapi and we probably need to add a exception as
this is neither source nor binary breaking. Copy from CI run
```
java.class.defaultSerializationChanged: The default serialization ID for
the class has changed. This means that the new version of the class is not
deserializable from the byte stream of a serialized old class.
old: class org.apache.iceberg.RewriteTablePathUtil.RewriteResult<T extends
java.lang.Object>
new: class org.apache.iceberg.RewriteTablePathUtil.RewriteResult<T extends
java.lang.Object>
SOURCE: EQUIVALENT, BINARY: EQUIVALENT, SEMANTIC: BREAKING
From old archive: iceberg-core-1.9.0.jar
From new archive: iceberg-core-d356455.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
