wgtmac commented on code in PR #181:
URL: https://github.com/apache/iceberg-cpp/pull/181#discussion_r2296117413
##########
src/iceberg/manifest_reader_internal.cc:
##########
@@ -567,4 +567,11 @@ Result<std::vector<ManifestFile>>
ManifestListReaderImpl::Files() const {
return manifest_files;
}
+Result<ManifestFileField> ManifestFileFieldFromIndex(int32_t index) {
+ if (index >= 0 && index < static_cast<int32_t>(ManifestFileField::kNextId)) {
Review Comment:
Why? The 1st value is always at index 0 regardless of its name. Perhaps
`kNextId` is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
