mapleFU commented on code in PR #180:
URL: https://github.com/apache/iceberg-cpp/pull/180#discussion_r2296180964
##########
src/iceberg/schema.cc:
##########
@@ -19,12 +19,46 @@
#include "iceberg/schema.h"
+#include <algorithm>
#include <format>
#include "iceberg/type.h"
#include "iceberg/util/formatter.h" // IWYU pragma: keep
+#include "iceberg/util/macros.h"
+#include "iceberg/util/visit_type.h"
namespace iceberg {
+class IdToFieldVisitor {
Review Comment:
Visitor is naming of the pattern, and Builder means it's used to build
`id_to_field`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
