pvary commented on pull request #1564:
URL: https://github.com/apache/iceberg/pull/1564#issuecomment-708167706


   > H @pvary, properties set in 
HiveIcebergStorageHandler.configureInputJobProperties() should propagate to the 
configuration object. Hive does copying of properties 
[here](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java#L408)
   > Another way to set would be through 
HiveIcebergStorageHandler.configureJobConf() . Were the properties still not 
transferred after this?
   
   @HotSushi: Thanks for the quick answer! In my last patch I try to load the 
schema from the `conf` and if not successful then from the `serDeProperties`. 
This means then one of the checks is unnecessary and I can remove it. I was 
just afraid that this is again some Hive 1.1 difference which we have to handle.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to