Guosmilesmile commented on code in PR #13853:
URL: https://github.com/apache/iceberg/pull/13853#discussion_r2296612034
##########
docs/docs/flink-table-maintenance.md:
##########
@@ -171,16 +172,17 @@ env.execute("Table Maintenance Job");
| Method | Description | Default Value | Type |
|--------|-------------|---------------|------|
| `targetFileSizeBytes(long)` | Target size for rewritten files | Table
property or 512MB | long |
-| `minFileSizeBytes(long)` | Minimum size of files eligible for compaction | 0
| long |
-| `maxFileSizeBytes(long)` | Maximum size of files eligible for compaction |
Long.MAX_VALUE | long |
-| `minInputFiles(int)` | Minimum number of files to trigger rewrite | 1 | int |
+| `minFileSizeBytes(long)` | Minimum size of files eligible for compaction |
75% of target file size | long |
+| `maxFileSizeBytes(long)` | Maximum size of files eligible for compaction |
180% of target file size | long |
+| `minInputFiles(int)` | Minimum number of files to trigger rewrite | 5 | int |
| `deleteFileThreshold(int)` | Minimum delete-file count per data file to
force rewrite | Integer.MAX_VALUE | int |
| `rewriteAll(boolean)` | Rewrite all data files regardless of thresholds |
false | boolean |
| `maxFileGroupSizeBytes(long)` | Maximum total size of a file group |
107374182400 (100GB) | long |
-| `maxFilesToRewrite(int)` | Maximum number of files to rewrite per task |
Integer.MAX_VALUE | int |
+| `maxFilesToRewrite(int)` | About the description we can add: If this option
is not specified, all eligible files will be rewritten | null | int |
| `partialProgressEnabled(boolean)` | Enable partial progress commits | false
| boolean |
| `partialProgressMaxCommits(int)` | Maximum commits allowed for partial
progress when partialProgressEnabled is true | 10 | int |
| `maxRewriteBytes(long)` | Maximum bytes to rewrite per execution |
Long.MAX_VALUE | long |
+| `filter(Expression)` | Filter expression for selecting files to rewrite |
null | Expression |
Review Comment:
Default value is `Expressions.alwaysTrue()`
##########
docs/docs/flink-table-maintenance.md:
##########
@@ -171,16 +172,17 @@ env.execute("Table Maintenance Job");
| Method | Description | Default Value | Type |
|--------|-------------|---------------|------|
| `targetFileSizeBytes(long)` | Target size for rewritten files | Table
property or 512MB | long |
-| `minFileSizeBytes(long)` | Minimum size of files eligible for compaction | 0
| long |
-| `maxFileSizeBytes(long)` | Maximum size of files eligible for compaction |
Long.MAX_VALUE | long |
-| `minInputFiles(int)` | Minimum number of files to trigger rewrite | 1 | int |
+| `minFileSizeBytes(long)` | Minimum size of files eligible for compaction |
75% of target file size | long |
+| `maxFileSizeBytes(long)` | Maximum size of files eligible for compaction |
180% of target file size | long |
+| `minInputFiles(int)` | Minimum number of files to trigger rewrite | 5 | int |
| `deleteFileThreshold(int)` | Minimum delete-file count per data file to
force rewrite | Integer.MAX_VALUE | int |
| `rewriteAll(boolean)` | Rewrite all data files regardless of thresholds |
false | boolean |
| `maxFileGroupSizeBytes(long)` | Maximum total size of a file group |
107374182400 (100GB) | long |
-| `maxFilesToRewrite(int)` | Maximum number of files to rewrite per task |
Integer.MAX_VALUE | int |
+| `maxFilesToRewrite(int)` | About the description we can add: If this option
is not specified, all eligible files will be rewritten | null | int |
Review Comment:
We don't need `About the description we can add: ` in the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
