wgtmac commented on PR #182: URL: https://github.com/apache/iceberg-cpp/pull/182#issuecomment-3218099048
I guess we cannot port `arrow/util/decimal.h` without significant change due to dependency on arrow utilities. My concern is that we use `std::array<uint64_t, 2>` as the internal representation but use `int128_t` for testing. I'm not sure if we can directly use `int128_t` as the physical representation for the `Decimal` class. I did exactly this when I worked for my previous employer and it should work well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
