gabeiglio commented on code in PR #2154:
URL: https://github.com/apache/iceberg-python/pull/2154#discussion_r2294658737
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -172,6 +182,18 @@ def transform_properties_dict_value_to_str(cls,
properties: Properties) -> Dict[
return transform_dict_value_to_str(properties)
+class CreateViewRequest(IcebergBaseModel):
+ name: str = Field()
+ location: Optional[str] = Field()
+ view_schema: Schema = Field(alias="schema")
Review Comment:
nit:
```suggestion
location: Optional[str] = Field()
view: Schema = Field(alias="schema")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
