pvary commented on code in PR #13870:
URL: https://github.com/apache/iceberg/pull/13870#discussion_r2297560279
##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -152,9 +152,8 @@ public void testPositionDeleteMetrics() throws IOException {
writerFactory.newPositionDeleteWriter(outputFile, table.spec(), null);
try {
- T deletedRow = toRow(3, "3", true, 3L);
PositionDelete<T> positionDelete = PositionDelete.create();
- positionDelete.set("File A", 1, deletedRow);
+ positionDelete.set("File A", 1);
Review Comment:
This method is already there.
We can formally deprecate only two methods in the `PositionDelete`. We need
to keep the row schema in the other places as they are used by the equality
deletes.
The interesting thing is `PositionDeletesTable` which will not contain the
row after this. We can keep the column, but it will be always empty, but that
seems right. This is the same for every V3 tables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
