nandorKollar commented on PR #13880: URL: https://github.com/apache/iceberg/pull/13880#issuecomment-3227486858
> So in the case above we have dictionary encoded pages which allocate IntVectors which are then replaced with BaseVarWidthVectors for non encoded pages. This means we drop the previous vector and it's allocation with each swap. The more pages the worse it is. Why did they type of the vector change from IntVectors to BaseVarWidthVectors? If we clear out "this.vec" if it is set, wouldn't this type change in the vector cause problems? Shouldn't we explicitly close the `this.vec` if it is not null, before setting it to a new vector? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
