HeartLinked commented on code in PR #193: URL: https://github.com/apache/iceberg-cpp/pull/193#discussion_r2303477733
########## dev/release/rat_exclude_files.txt: ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +.gitignore +LICENSE +NOTICE +CONTRIBUTING.md +CHANGELOG.md +build/** +dist/** +.git/** +cmake_modules/** +.cmake/** +test/resources/** +*.avro +*.json +*.parquet Review Comment: Thank you for your review! I still believe we need to include these binary files, especially as they are part of our tests and are used exclusively for unit testing. I found that the release version of iceberg-rust also contains similar files (e.g., iceberg-rust/crates/iceberg/testdata/manifests_lists/manifest-list-v2-1.avro), so I think it is necessary to keep them here for now. This seems to be related to the current lack of support for relative paths in Apache Iceberg (see: [Google Docs link](https://docs.google.com/document/d/1a6tXvbWVbvOxiRexCiaIsIA6NOOqcbxPKjeoJGqgYtg/edit?pli=1&tab=t.p92mo7cvg08q)). In the future, we could potentially store these test files in a separate repository, similar to how apache/parquet-testing is managed. ########## dev/release/rat_exclude_files.txt: ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +.gitignore +LICENSE +NOTICE +CONTRIBUTING.md +CHANGELOG.md +build/** +dist/** +.git/** +cmake_modules/** +.cmake/** +test/resources/** +*.avro +*.json +*.parquet Review Comment: Thank you for your review! I still believe we need to include these binary files, especially as they are part of our tests and are used for unit testing. I found that the release version of iceberg-rust also contains similar files (e.g., iceberg-rust/crates/iceberg/testdata/manifests_lists/manifest-list-v2-1.avro), so I think it is necessary to keep them here for now. This seems to be related to the current lack of support for relative paths in Apache Iceberg (see: [Google Docs link](https://docs.google.com/document/d/1a6tXvbWVbvOxiRexCiaIsIA6NOOqcbxPKjeoJGqgYtg/edit?pli=1&tab=t.p92mo7cvg08q)). In the future, we could potentially store these test files in a separate repository, similar to how apache/parquet-testing is managed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
