slfan1989 commented on code in PR #13907: URL: https://github.com/apache/iceberg/pull/13907#discussion_r2305919071
########## spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestStoragePartitionedJoins.java: ########## @@ -133,7 +133,48 @@ public void removeTables() { sql("DROP TABLE IF EXISTS %s", tableName(OTHER_TABLE_NAME)); } - // TODO: add tests for truncate transforms once SPARK-40295 is released + // TODO: SPJ does not currently leverage truncate(...) partition transforms for partition + // alignment. + // SPARK-40295 improved related areas, but full truncate support is tracked in SPARK-50593. + // This test documents current behavior; update/extend once SPARK-50593 lands. + @TestTemplate + public void testJoinWithTruncatePartitioning() { + Review Comment: Thanks for your suggestion, I will improve this code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org