RussellSpitzer commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2307932712
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/parquet/vectorized/TestParquetVectorizedReads.java:
##########
@@ -161,28 +164,34 @@ void assertRecordsMatch(
boolean reuseContainers,
int batchSize)
throws IOException {
- Parquet.ReadBuilder readBuilder =
- Parquet.read(inputFile)
- .project(schema)
- .recordsPerBatch(batchSize)
- .createBatchedReaderFunc(
- type ->
- VectorizedSparkParquetReaders.buildReader(
- schema, type, Maps.newHashMap(), null));
- if (reuseContainers) {
- readBuilder.reuseContainers();
- }
- try (CloseableIterable<ColumnarBatch> batchReader = readBuilder.build()) {
- Iterator<GenericData.Record> expectedIter = expected.iterator();
- Iterator<ColumnarBatch> batches = batchReader.iterator();
- int numRowsRead = 0;
- while (batches.hasNext()) {
- ColumnarBatch batch = batches.next();
- numRowsRead += batch.numRows();
- TestHelpers.assertEqualsBatch(schema.asStruct(), expectedIter, batch);
- }
- assertThat(numRowsRead).isEqualTo(expectedSize);
- }
+ assertNoLeak(
+ "testRecordsMatch",
Review Comment:
ah yeah, we don't have it at this point in the call, originally I was just
using the file name of what's being read ... Let me see if I can get it from
JUNIT somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
