joellubi commented on code in PR #552: URL: https://github.com/apache/iceberg-go/pull/552#discussion_r2310835092
########## catalog/rest/rest.go: ########## @@ -194,8 +194,7 @@ type configResponse struct { } type sessionTransport struct { - http.Transport - + transport http.RoundTripper Review Comment: We can also embed the interface instead of making it into an unexported field, similar to how it was before. That change wasn't necessary. I just pushed that up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org