RussellSpitzer commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r505831083
##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -107,4 +112,47 @@ public static boolean ancestorOf(Table table, long
snapshotId, long ancestorSnap
return newFiles;
}
+
+ public static List<Snapshot> snapshotsWithin(Table table, long
fromSnapshotId, long toSnapshotId) {
+ List<Long> snapshotIds = SnapshotUtil.snapshotIdsBetween(table,
fromSnapshotId, toSnapshotId);
+ List<Snapshot> snapshots = Lists.newArrayList();
+ for (Long snapshotId : snapshotIds) {
+ Snapshot snapshot = table.snapshot(snapshotId);
+ // for now, incremental scan supports only appends
+ if (snapshot.operation().equals(DataOperations.APPEND)) {
+ snapshots.add(snapshot);
+ } else if (snapshot.operation().equals(DataOperations.OVERWRITE)) {
+ throw new UnsupportedOperationException(
+ String.format("Found %s operation, cannot support incremental data
in snapshots (%s, %s]",
+ DataOperations.OVERWRITE, fromSnapshotId, toSnapshotId));
+ }
+ }
+ return snapshots;
+ }
+
+ public static void validateSnapshotIdsRefinement(long newFromSnapshotId,
long newToSnapshotId, Table table,
+ TableScanContext context) {
+ Set<Long> snapshotIdsRange = Sets.newHashSet(
+ SnapshotUtil.snapshotIdsBetween(table, context.fromSnapshotId(),
context.toSnapshotId()));
Review comment:
It could be large but this would only be used during incremental scans
which should have bounded requests of Ids (those for a given time range) as
opposed to normal scans which would just use a single snapshot id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
