zeroshade commented on code in PR #524:
URL: https://github.com/apache/iceberg-go/pull/524#discussion_r2314376993
##########
manifest.go:
##########
@@ -37,6 +37,19 @@ import (
"github.com/hamba/avro/v2/ocf"
)
+func init() {
+ avro.Register("fixed", [1]byte{})
+ avro.Register("fixed", [2]byte{})
+ avro.Register("fixed", [3]byte{})
+ avro.Register("fixed", [4]byte{})
+ avro.Register("fixed", [5]byte{})
+ avro.Register("fixed", [6]byte{})
+ avro.Register("fixed", [7]byte{})
+ avro.Register("fixed", [8]byte{})
+ avro.Register("fixed", [16]byte{})
Review Comment:
According to the `hambra` documentation, it should automatically decode
`fixed` to `[n]byte` without needing these, do we have a test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
