liurenjie1024 commented on code in PR #1630:
URL: https://github.com/apache/iceberg-rust/pull/1630#discussion_r2315518434
##########
crates/sqllogictest/src/engine/datafusion.rs:
##########
@@ -61,6 +51,16 @@ impl Engine for DataFusionEngine {
}
impl DataFusionEngine {
+ pub async fn new(config: TomlTable) -> Result<Self> {
Review Comment:
Why we move this out of trait?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
