smaheshwar-pltr commented on code in PR #14014:
URL: https://github.com/apache/iceberg/pull/14014#discussion_r2328748940
##########
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java:
##########
@@ -462,13 +462,15 @@ public <T> Boolean notIn(BoundReference<T> ref, Set<T>
literalSet) {
@Override
public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
+ // TODO: Handle cases that definitely match predicate, such as
startsWith("x") when the bounds
+ // are ["xa", "xz"]
return ROWS_MIGHT_NOT_MATCH;
}
@Override
public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
- // TODO: Handle cases that definitely cannot match, such as
notStartsWith("x") when the bounds
Review Comment:
This is a nit - this wording felt slightly confusing because this case
matches the predicate but not the prefix, so clarified
##########
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java:
##########
@@ -462,13 +462,15 @@ public <T> Boolean notIn(BoundReference<T> ref, Set<T>
literalSet) {
@Override
public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
+ // TODO: Handle cases that definitely match predicate, such as
startsWith("x") when the bounds
+ // are ["xa", "xz"]
Review Comment:
Opened https://github.com/apache/iceberg/issues/14016 to track
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
