sumanth-manchala commented on PR #1653: URL: https://github.com/apache/iceberg-rust/pull/1653#issuecomment-3264450414
> LGTM! > > I verified locally for both sdist and wheel > > ``` > maturin sdist -o dist > tar -tzf dist/pyiceberg_core-*.tar.gz | grep -E '/(LICENSE|NOTICE)$' > > pyiceberg_core-0.6.0/crates/iceberg/LICENSE > pyiceberg_core-0.6.0/crates/iceberg/NOTICE > pyiceberg_core-0.6.0/crates/integrations/datafusion/LICENSE > pyiceberg_core-0.6.0/crates/integrations/datafusion/NOTICE > pyiceberg_core-0.6.0/bindings/python/LICENSE > pyiceberg_core-0.6.0/bindings/python/NOTICE > pyiceberg_core-0.6.0/LICENSE > pyiceberg_core-0.6.0/NOTICE > > maturin build --release -o dist > tar -tzf dist/pyiceberg_core-*.whl | grep -E '/(LICENSE|NOTICE)$' > > pyiceberg_core-0.6.0.dist-info/licenses/LICENSE > pyiceberg_core-0.6.0.dist-info/licenses/NOTICE > ``` > > Pasting the [ASF policy](https://www.apache.org/legal/release-policy.html#licensing-documentation), > > > For source packages, LICENSE and NOTICE MUST be located at the root of the distribution. For additional packages, they MUST be located in the distribution format's customary location for licensing materials, such as the META-INF directory of Java "jar" files. > > source package is located at the root. > wheel package is in the licenses/ folder > > Thanks @kevinjqliu !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
