stevenzwu commented on pull request #1625: URL: https://github.com/apache/iceberg/pull/1625#issuecomment-711490862
@JingsongLi `DataIterator<T>` is for generic type T, which could be an Avro GenericRecord or sth else. Currently, `convertConstant` method deals with Flink data types used by `RowData` (like DecimalData, StringData, TimestampData etc.). If there is a new `BatchDataIterator` impl for a different type `T`, I would imagine that we may need a diff impl of `convertConstant `. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
