RussellSpitzer commented on PR #13976:
URL: https://github.com/apache/iceberg/pull/13976#issuecomment-3271914931

   > Actually when we close the allocators, which is implemented in this PR, 
now we do have failing tests in Spark (though they're a bit hard to debug why), 
when reuse vector fix in last update sequence, and rowId readers are not there. 
So the original recommendation made by Russel to close the allocators looks 
important. Nevertheless, I can investigate how to add an extra test case just 
for these two vectors, could you please help to find the best test class for 
such a test case?
   
   Could we add this to the suite I modified before? I think we just need to 
add the last_updated_seq and _row_id to the schema and it should do it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to