mxm commented on code in PR #14044:
URL: https://github.com/apache/iceberg/pull/14044#discussion_r2336933104


##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkExtended.java:
##########
@@ -134,7 +134,7 @@ public void testTwoSinksInDisjointedDAG() throws Exception {
 
     List<Row> leftRows = createRows("left-");
     DataStream<Row> leftStream =
-        env.fromCollection(leftRows, ROW_TYPE_INFO)
+        env.addSource(createBoundedSource(leftRows), ROW_TYPE_INFO)

Review Comment:
   A bit of context: `createdBoundedSource` uses a special source which emits 
the records, then waits for the checkpoint to get triggered before shutting 
down. See 
https://github.com/apache/iceberg/blob/36d9c1b3920434c977d205decf174185de725edb/flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/BoundedTestSource.java#L93.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to