RussellSpitzer commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r2342384276
##########
core/src/main/java/org/apache/iceberg/ManifestListWriter.java:
##########
@@ -29,9 +33,25 @@
abstract class ManifestListWriter implements FileAppender<ManifestFile> {
private final FileAppender<ManifestFile> writer;
+ private final StandardEncryptionManager standardEncryptionManager;
+ private final NativeEncryptionKeyMetadata manifestListKeyMetadata;
+ private final OutputFile outputFile;
+
+ private ManifestListWriter(
+ OutputFile file, EncryptionManager encryptionManager, Map<String,
String> meta) {
+ if (encryptionManager instanceof StandardEncryptionManager) {
+ // ability to encrypt the manifest list key is introduced for standard
encryption.
+ this.standardEncryptionManager = (StandardEncryptionManager)
encryptionManager;
+ NativeEncryptionOutputFile encryptedFile =
this.standardEncryptionManager.encrypt(file);
Review Comment:
I was very confused by this when I was working on Parquet Manifests, it's a
little weird that the method returns NativeEncyrptionOutputFile but it's
actually a StandardEncryptionOuputFile. Maybe it's too late but I wonder if we
should change the names of those classes. We can save this for another PR
though.
The base class being Native just is confusing to me because the subclass
obviously isn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
