jshmchenxi commented on PR #14041: URL: https://github.com/apache/iceberg/pull/14041#issuecomment-3290778054
> > cc @huaxingao @rdblue > > Any suggestion of how this should be tested would be appreciated. Currently I don't see any test for the class `ParquetFilters`. > > I think this is always used via Parquet.java > > https://github.com/apache/iceberg/blob/05cd8b52e7d06d0d246475bd11f138d25947fd13/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java#L1417 > > So I think almost all of our current coverage is downstream of actual implementations using Parquet.read.filter() which is a problem. So Theoretically and test with an IN clause in it for any engine should hit this but I feel like we should probably have some explicit unit tests of this? Sounds good. I'll add explicit unit tests for `ParquetFilters.convert`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
