Fokko commented on code in PR #2465: URL: https://github.com/apache/iceberg-python/pull/2465#discussion_r2348216507
########## Makefile: ########## @@ -21,13 +21,20 @@ PYTEST_ARGS ?= -v # Override with e.g. PYTEST_ARGS="-vv --tb=short" COVERAGE ?= 0 # Set COVERAGE=1 to enable coverage: make test COVERAGE=1 COVERAGE_FAIL_UNDER ?= 85 # Minimum coverage % to pass: make coverage-report COVERAGE_FAIL_UNDER=70 +KEEP_COMPOSE ?= 0 # Set KEEP_COMPOSE=1 to keep containers after integration tests ifeq ($(COVERAGE),1) TEST_RUNNER = poetry run coverage run --parallel-mode --source=pyiceberg -m else TEST_RUNNER = poetry run endif +ifeq ($(KEEP_COMPOSE),1) + CLEANUP_COMMAND = echo "Keeping containers running for debugging (KEEP_COMPOSE=1)" +else + CLEANUP_COMMAND = docker compose -f dev/docker-compose-integration.yml down -v --remove-orphans 2>/dev/null || true Review Comment: I would not be in favor of supporting the EOL `docker-compose` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
