nullccxsy commented on code in PR #227:
URL: https://github.com/apache/iceberg-cpp/pull/227#discussion_r2349483553


##########
src/iceberg/schema.h:
##########
@@ -48,6 +49,10 @@ class ICEBERG_EXPORT Schema : public StructType {
   explicit Schema(std::vector<SchemaField> fields,
                   std::optional<int32_t> schema_id = std::nullopt);
 
+  Schema(const Schema& other);

Review Comment:
   Yes, if we don't use the operation of copy, there will no problem. I have 
modified the parts where copy operations are needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to