rodmeneses commented on code in PR #14063:
URL: https://github.com/apache/iceberg/pull/14063#discussion_r2350123552
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java:
##########
@@ -663,9 +663,13 @@ IcebergSink build() {
}
}
}
-
FlinkMaintenanceConfig flinkMaintenanceConfig =
new FlinkMaintenanceConfig(table, writeOptions, readableConfig);
+
+ if (flinkWriteConf.uidSuffix() != null) {
+ uidSuffix = flinkWriteConf.uidSuffix();
+ }
Review Comment:
Hi @pvary thanks for the review.
in the `build()` method, we were already using `flinkWriteConf.upsertMode()`
and `flinkWriteConf.overwriteMode()` ... that's why it was decided to make the
code change there.
Where were you proposing to make that change instead?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
