nastra commented on code in PR #14060:
URL: https://github.com/apache/iceberg/pull/14060#discussion_r2348277092
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -22,9 +22,17 @@ public final class RESTCatalogProperties {
private RESTCatalogProperties() {}
+ /** The name of the REST catalog startup parameter to configure default
snapshot loading mode. */
public static final String SNAPSHOT_LOADING_MODE = "snapshot-loading-mode";
+
public static final String SNAPSHOT_LOADING_MODE_DEFAULT =
SnapshotMode.ALL.name();
+ /**
+ * The name of the query parameter to be used in the load table endpoint of
the REST catalog
+ * server to set the snapshot loading mode.
+ */
+ public static final String SNAPSHOT_MODE_PARAM_NAME = "snapshots";
Review Comment:
so this one is actually a query param and not a catalog property, therefore
I don't think it should be part of this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
