nastra commented on code in PR #13837: URL: https://github.com/apache/iceberg/pull/13837#discussion_r2352858504
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java: ########## @@ -58,14 +60,19 @@ public class RewriteTablePathProcedure extends BaseProcedure { TARGET_PREFIX_PARAM, START_VERSION_PARAM, END_VERSION_PARM, - STAGING_LOCATION_PARAM + STAGING_LOCATION_PARAM, + CREATE_FILE_LIST_PARAM }; private static final StructType OUTPUT_TYPE = new StructType( new StructField[] { new StructField("latest_version", DataTypes.StringType, true, Metadata.empty()), - new StructField("file_list_location", DataTypes.StringType, true, Metadata.empty()) + new StructField("file_list_location", DataTypes.StringType, true, Metadata.empty()), + new StructField( + "rewritten_metadata_files_count", DataTypes.IntegerType, true, Metadata.empty()), Review Comment: we would need to update the naming here as well to indicate that these are referring to paths -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org