Fokko commented on code in PR #2432: URL: https://github.com/apache/iceberg-python/pull/2432#discussion_r2353408060
########## pyiceberg/io/pyarrow.py: ########## @@ -690,16 +692,20 @@ def schema_to_pyarrow( schema: Union[Schema, IcebergType], metadata: Dict[bytes, bytes] = EMPTY_DICT, include_field_ids: bool = True, + file_format: Optional[FileFormat] = None, Review Comment: How about setting this explicitly, avoiding on option: ```suggestion file_format: FileFormat = FileFormat.Parquet, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org